MLE-24755 - fix intermittent errors (hopefully): change to use modern… #1002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Copyright Validation Results ✅ Valid Files
✅ All files have valid copyright headers! |
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes Node.js test files by replacing callback-based patterns with modern async/await syntax and Promises, specifically targeting intermittent test errors. The changes aim to improve test reliability and code comprehension by eliminating complex nested callback structures.
Key changes:
- Convert all test functions from callback-based (
done()) toasync/awaitpattern - Replace nested
.then()/.catch()chains with Promise-based patterns - Remove incorrect assertions about batch completion document counts
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test-complete/nodejs-dmsdk-queryToTransformAll.js | Converts all test functions to async/await, removes problematic batch size assertions, and modernizes Promise handling |
| test-complete/nodejs-dmsdk-UpdAndRdAll.js | Updates from var/callback patterns to const/async-await, adds stream pipeline usage, and improves test structure |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
stevebio
force-pushed
the
feature/MLE-24755-data-movement-fixes
branch
3 times, most recently
from
740ef43 to
e00d937
Compare
anu3990
approved these changes
Oct 20, 2025
|
This is worth a shot. |
rjrudin
approved these changes
Oct 20, 2025
…romise objects to make test logic comprehension easier. Remove the incorrect assertion that on the first and subsequent call to onBatchSuccess that the number of transformed documents is always greater than or equal to the batch size. This is not always the case, sometimes on the first callback the number of transformed docs in the summary is less than the batch size.
stevebio
force-pushed
the
feature/MLE-24755-data-movement-fixes
branch
from
e00d937 to
d502ed1
Compare
anu3990
approved these changes
Oct 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… await and Promise objects to make test logic comprehension easier. Remove the incorrect assertion that on the first and subsequent call to onBatchSuccess that the number of transformed documents is always greater than or equal to the batch size. This is not always the case. Sometimes on the first callback the number of transformed docs in the summary is less than the batch size.